Aio circleci builds patch #25554
Closed
Aio circleci builds patch #25554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now instead of pushing the AIO build artifacts to the preview server from inside a Travis job, the artifacts are built and hosted on the CircleCI infrastructure. The preview server will then pull these down after being triggered by a CircleCI build webhook.
…ircleCI Previously, Travis pushed the build artitfacts to the preview server. This required us to use JWT to secure the POST request from Travis, to ensure we couldn't receive malicious builds. JWT has been deprecated and we are moving our builds to CircleCI. This commit rewrites the TypeScript part of the preview server that handles converting build artifact into hosted previews of the docs.
The server no longer has files uploaded to it. Instead it is more accurate to refer to it as dealing with "previews" of PRs.
|
You can preview ced5754 at https://pr25554-ced5754.ngbuilds.io/. |
jasonaden
approved these changes
Aug 17, 2018
jasonaden
added
action: merge
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
Now instead of pushing the AIO build artifacts to the preview server from inside a Travis job, the artifacts are built and hosted on the CircleCI infrastructure. The preview server will then pull these down after being triggered by a CircleCI build webhook. PR Close #25554
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
…ircleCI (#25554) Previously, Travis pushed the build artitfacts to the preview server. This required us to use JWT to secure the POST request from Travis, to ensure we couldn't receive malicious builds. JWT has been deprecated and we are moving our builds to CircleCI. This commit rewrites the TypeScript part of the preview server that handles converting build artifact into hosted previews of the docs. PR Close #25554
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
The server no longer has files uploaded to it. Instead it is more accurate to refer to it as dealing with "previews" of PRs. PR Close #25554
jasonaden
pushed a commit
that referenced
this pull request
Aug 17, 2018
|
Merged |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAO: @jasonaden